Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acceptance test for liveness endpoint #4509

Merged
merged 8 commits into from
Oct 24, 2021
Merged

Acceptance test for liveness endpoint #4509

merged 8 commits into from
Oct 24, 2021

Conversation

rolfyone
Copy link
Contributor

partially addresses #4453

Signed-off-by: Paul Harris [email protected]

Documentation

  • I thought about documentation and added the documentation label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

ajsutton
ajsutton reviewed Oct 21, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good generally, just a couple of tweaks.

.../acceptance-test/java/tech/pegasys/teku/test/acceptance/ValidatorLivenessAcceptanceTest.java Outdated Show resolved Hide resolved
acceptance-tests/src/testFixtures/java/tech/pegasys/teku/test/acceptance/dsl/TekuNode.java Outdated Show resolved Hide resolved
acceptance-tests/src/testFixtures/java/tech/pegasys/teku/test/acceptance/dsl/TekuNode.java Outdated Show resolved Hide resolved
...rc/testFixtures/java/tech/pegasys/teku/test/acceptance/dsl/ValidatorLivenessExpectation.java Outdated Show resolved Hide resolved
ajsutton
ajsutton approved these changes Oct 24, 2021
View reviewed changes
Copy link
Contributor

@ajsutton ajsutton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rolfyone rolfyone enabled auto-merge (squash) October 24, 2021 20:51
@rolfyone rolfyone merged commit 7b6b824 into Consensys:master Oct 24, 2021
@rolfyone rolfyone deleted the 4453-acceptance-test branch October 24, 2021 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajsutton ajsutton ajsutton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rolfyone @ajsutton