Add a cache to track liveness of validators #4489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cache is specifically needed to service rest api requests, so is not required if we are not using the rest api. The rest endpoint is yet to be approved, so leaving it marked experimental until the endpoint is finalized. Currently feature flagged with 'Xbeacon-liveness-tracking-enabled', which is a hidden CLI option. Enabling will keep a 2d array of as much as 3x (the max validator index+1000) to maintain where validators have been seen. partially addresses Consensys#4453 Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
ajsutton
reviewed
Oct 15, 2021
.../java/tech/pegasys/teku/beaconrestapi/v1/validator/PostValidatorLivenessIntegrationTest.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/teku/beaconrestapi/v1/validator/PostValidatorLivenessIntegrationTest.java
Outdated
Show resolved
Hide resolved
data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.java
Outdated
Show resolved
Hide resolved
data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/tech/pegasys/teku/statetransition/validatorcache/ActiveValidatorCache.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/tech/pegasys/teku/statetransition/validatorcache/ActiveValidatorCache.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/tech/pegasys/teku/statetransition/validatorcache/ActiveValidatorCache.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/tech/pegasys/teku/statetransition/validatorcache/ActiveValidatorCache.java
Outdated
Show resolved
Hide resolved
...ion/src/main/java/tech/pegasys/teku/statetransition/validatorcache/ActiveValidatorCache.java
Outdated
Show resolved
Hide resolved
...src/test/java/tech/pegasys/teku/statetransition/validatorcache/ActiveValidatorCacheTest.java
Show resolved
Hide resolved
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
Signed-off-by: Paul Harris <[email protected]>
ajsutton
approved these changes
Oct 17, 2021
data/provider/src/main/java/tech/pegasys/teku/api/NodeDataProvider.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cache is specifically needed to service rest api requests, so is not required if we are not using the rest api.
The rest endpoint is yet to be approved, so leaving it marked experimental until the endpoint is finalized.
Currently feature flagged with 'Xbeacon-liveness-tracking-enabled', which is a hidden CLI option.
Enabling will keep a 2d array of as much as 3x (the max validator index+1000) to maintain where validators have been seen.
partially addresses #4453
Signed-off-by: Paul Harris [email protected]
Documentation
documentationlabel to this PR if updates are required.Changelog