Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Solidity 0.8.21 #219

Merged
merged 5 commits into from
Aug 15, 2023
Merged

Support for Solidity 0.8.21 #219

merged 5 commits into from
Aug 15, 2023

Conversation

blitz-1306
Copy link
Contributor

@blitz-1306 blitz-1306 commented Jul 20, 2023

Changes

  • Updated dependencies.
  • Added support of Solidity 0.8.21 on compiler level.
  • Partially update test snapshots due to issues with compiler.

Notes

There is an issue with this compiler, that is tracked here: ethereum/solidity#14430. Until it is resolved, this PR will stay in draft state due to limitation of ways to express some introduced syntax features.

UPD: It seems that solc-typed-ast is not affected by compiler bug that much. Still, dependent packages should avoid using dev-docs option while compiling to not cause compiler failure.

Related links

Regards.

@blitz-1306 blitz-1306 added the enhancement New feature or request label Jul 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Merging #219 (2567575) into master (7d06f0e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #219   +/-   ##
=======================================
  Coverage   91.74%   91.74%           
=======================================
  Files         267      267           
  Lines        6550     6551    +1     
  Branches     1320     1320           
=======================================
+ Hits         6009     6010    +1     
  Misses        287      287           
  Partials      254      254           
Files Changed Coverage Δ
src/compile/constants.ts 100.00% <ø> (ø)
src/compile/kinds/compiler.ts 79.26% <100.00%> (+0.25%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cd1m0
cd1m0 previously approved these changes Jul 20, 2023
Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blitz-1306 blitz-1306 marked this pull request as ready for review August 14, 2023 05:24
@blitz-1306 blitz-1306 requested a review from cd1m0 August 14, 2023 05:25
Copy link
Contributor

@cd1m0 cd1m0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@blitz-1306 blitz-1306 merged commit 78666e1 into master Aug 15, 2023
2 checks passed
@blitz-1306 blitz-1306 deleted the support-solidity-0821 branch August 15, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants