Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix basic auth parser #564

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix basic auth parser #564

wants to merge 1 commit into from

Conversation

toanalien
Copy link

@toanalien toanalien commented Jun 1, 2022

PR description

  • The Basic Auth parser is not correct. It includes a colon in the password.
  • password: thisissuperpassword
  • raw payload: :thisissuperpassword
  • Header with base64 encoded: Authorization: Basic OnRoaXNpc3N1cGVycGFzc3dvcmQ=

Fixed Issue(s)

  • Use http.Request.BasicAuth() parses authentication header.

@CLAassistant
Copy link

CLAassistant commented Jun 1, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants