Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs fix spelling issues #546

Open
wants to merge 3 commits into
base: fix/typos-v0.15
Choose a base branch
from
Open

Docs fix spelling issues #546

wants to merge 3 commits into from
+3 −3

Conversation

nnsW3
Copy link

@nnsW3 nnsW3 commented Sep 24, 2024

Hello
I fixed several spelling issues.
Br, Elias.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ivokub ivokub added the typo Typo fixes label Sep 25, 2024
ivokub
ivokub requested changes Dec 3, 2024
View reviewed changes
CHANGELOG.md
@@ -36,7 +36,7 @@
- resolve conflict around kzg

### Perf
- remove uneeded bucket init in affine coordinates fixes [#529](https://github.com/ConsenSys/gnark-crypto/issues/529) ([#530](https://github.com/ConsenSys/gnark-crypto/issues/530))
- remove unneeded bucket init in affine coordinates fixes [#529](https://github.com/ConsenSys/gnark-crypto/issues/529) ([#530](https://github.com/ConsenSys/gnark-crypto/issues/530))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert - CHANGELOG is automatically generated and the change will be overwritten.

ecc/bls12-377/multiexp_affine.go
@@ -72,7 +72,7 @@ func processChunkG1BatchAffine[BJE ibg1JacExtended, B ibG1Affine, BS bitSet, TP
cptAdd int // count the number of bucket + point added to current batch
R TPP // bucket references
P TP // points to be added to R (buckets); it is beneficial to store them on the stack (ie copy)
queue TQ // queue of points that conflict the current batch
queue TQ // queue of points that conflict with the current batch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also fix in other ecc packages.

@ivokub ivokub changed the base branch from master to fix/typos-v0.15 December 3, 2024 23:52
@ivokub
Copy link
Collaborator

ivokub commented Dec 3, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please sign CLA for being able to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub requested changes

Assignees
No one assigned
Labels
typo Typo fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nnsW3 @CLAassistant @ivokub