Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix comment of v for SetBigInt #541

Merged
merged 2 commits into from
Dec 4, 2024
Merged

fix comment of v for SetBigInt #541

merged 2 commits into from
Dec 4, 2024
+20 −20

Conversation

zhiqiangxu
Copy link
Contributor

We can only conclude v >= 0 instead of v > 0 from v.Cmp(&zero) != -1.

@CLAassistant
Copy link

CLAassistant commented Sep 19, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub added the typo Typo fixes label Sep 25, 2024
@ivokub ivokub changed the base branch from master to fix/typos-v0.15 December 3, 2024 23:59
@ivokub
Copy link
Collaborator

ivokub commented Dec 4, 2024

Thanks for the contribution! I also code generated the implementation for all curves. I'll merge to a branch which collects all documentation fixes which we merge before next release.

@ivokub ivokub merged commit 7b315c6 into Consensys:fix/typos-v0.15 Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
typo Typo fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhiqiangxu @CLAassistant @ivokub