Add GPU Acceleration Support for KZG Commitments #486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull-request adds support for running KZG Commitments on GPU within the icicle.go file. The reasoning for this commit is to provide GPU support for difficult to access functions such as
OnDeviceBatchOpenSinglePoint
which are hard/impossible to modify without forking the repository.Running KZG commits on GPU is generally 3-4x faster than the equivalent on CPU.
Type of change
How has this been tested?
New test
TestOnDeviceCommit
has been added to ```test_kzg.go``. For the test to work the user will need to have compiled Icicle library in path.Clone Icicle repository and checkout current Go language commit(our Go Icicle Cuda bindings are in the process of being updated)
Build Icicle
Once Icicle is compiled run tests inside gnark-crypto/ecc/bn254/kzg repository.
Checklist:
golangci-lint
does not output errors locally