-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gas estimation pages #758
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial feedback:
-
We currently mention, “Linea also supports eth_estimateGas, eth_gasPrice, and eth_feeHistory.” And link out to those methods in the Infura docs. But then we also document those methods in the topic. I recommend removing the API documentation from this topic and just leaving the links to the content. They are not the recommended methods for estimating gas anyway and we’re mixing reference and how to content.
-
This is a guide (or how to) on how to estimate gas. So we should perhaps have an example of using
linea_estimateGas
. Perhaps the example in the reference content will suffice. Then, if users want to learn more about the method and it’s parameters they can view the reference content. -
We currently mention, "linea_estimateGas will be fully activated on Mainnet on September 30." This date has passed so If it hasn't been activated then we should update this.
-
If
linea_estimateGas
is fully active, then do we still need all the the Compatibility mode documentation?
@bgravenorst thanks for the comments.
|
linea_estimateGas
is being activated today, September 30. This PR updates the gas estimation guide accordingly and also amends text in a few other places to reflect the endpoint being fully available.