Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gas estimation pages #758

Merged
merged 8 commits into from
Oct 7, 2024
Merged

Update gas estimation pages #758

merged 8 commits into from
Oct 7, 2024

Conversation

jlwllmr
Copy link
Collaborator

@jlwllmr jlwllmr commented Sep 30, 2024

linea_estimateGas is being activated today, September 30. This PR updates the gas estimation guide accordingly and also amends text in a few other places to reflect the endpoint being fully available.

@jlwllmr jlwllmr requested a review from bgravenorst September 30, 2024 10:19
Copy link

vercel bot commented Sep 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 3, 2024 1:20pm

Copy link
Collaborator

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial feedback:

  1. We currently mention, “Linea also supports eth_estimateGaseth_gasPrice, and eth_feeHistory.” And link out to those methods in the Infura docs. But then we also document those methods in the topic.
I recommend removing the API documentation from this topic and just leaving the links to the content. They are not the recommended methods for estimating gas anyway and we’re mixing reference and how to content.

  2. This is a guide (or how to) on how to estimate gas. So we should perhaps have an example of using linea_estimateGas. Perhaps the example in the reference content will suffice. Then, if users want to learn more about the method and it’s parameters they can view the reference content.

  3. We currently mention, "linea_estimateGas will be fully activated on Mainnet on September 30." This date has passed so If it hasn't been activated then we should update this.

  4. If linea_estimateGas is fully active, then do we still need all the the Compatibility mode documentation?

@jlwllmr
Copy link
Collaborator Author

jlwllmr commented Oct 3, 2024

@bgravenorst thanks for the comments.

  1. Yeah, that makes sense. Will adjust.
  2. Got it, will add in the example but leave out the details.
  3. Agreed, adjusting.
  4. I think we need this content for now, potentially for a few weeks. Not all providers will have switched over immediately.

@jlwllmr jlwllmr merged commit e67b658 into main Oct 7, 2024
9 checks passed
@jlwllmr jlwllmr deleted the gas-estimation-update branch October 7, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants