Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linea_getTransactionExclusionStatusV1 API reference #739

Merged
merged 26 commits into from
Sep 27, 2024
Merged

linea_getTransactionExclusionStatusV1 API reference #739

merged 26 commits into from
Sep 27, 2024

Conversation

jlwllmr
Copy link
Collaborator

@jlwllmr jlwllmr commented Sep 16, 2024

Documents the new method for retrieving details of transactions rejected by the sequencer because they exceed the prover's line limit.

@vercel Vercel
Copy link

vercel bot commented Sep 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 8:47am

@jonesho
Copy link

jonesho commented Sep 16, 2024

@jlwllmr it'd be nice if you could also mention if the given tx hash was not found, the result will be null:

{
    "jsonrpc": "2.0",
    "id": 1,
    "result": null
}

m4sterbunny
m4sterbunny suggested changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@m4sterbunny m4sterbunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nitpicks, + recommend checking that request b4 publishing

bgravenorst
bgravenorst approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@bgravenorst bgravenorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some additional feedback.

docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
docs/developers/reference/api/linea-gettransactionexclusionstatusv1.mdx Outdated Show resolved Hide resolved
@jlwllmr jlwllmr merged commit 285f78b into main Sep 27, 2024
9 checks passed
@jlwllmr jlwllmr deleted the tx-exclusion-api branch September 27, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonesho jonesho jonesho left review comments

@bgravenorst bgravenorst bgravenorst approved these changes

@m4sterbunny m4sterbunny m4sterbunny approved these changes

@julien-marchand julien-marchand julien-marchand left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jlwllmr @jonesho @julien-marchand @m4sterbunny @bgravenorst