Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gas estimation pages #718

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Update gas estimation pages #718

merged 9 commits into from
Sep 9, 2024

Conversation

jlwllmr
Copy link
Collaborator

@jlwllmr jlwllmr commented Sep 5, 2024

  • Replaces linea_estimateGas-centric instructions in gas-fees.mdx with details of how to use eth_gasPrice, eth_feeHistory, and eth_estimateGas, since these are the available options until linea_estimateGas is activated
  • Moves some explanatory content about linea_estimateGas from gas-fees.mdx to its reference page
  • Clarifies copy generally and about the availability of linea_estimateGas, and adds some detail about the EIP-1559 formula and how it applies to Linea

fixes #717

Copy link

vercel bot commented Sep 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 4:29pm

@jlwllmr jlwllmr requested a review from bgravenorst September 5, 2024 16:12
@mapachurro
Copy link
Collaborator

Can't figure out the capitalization of curl. This Wikipedia page seems intentional about it but I don't see any clarification about when and where: https://en.wikipedia.org/wiki/CURL

docs/developers/guides/gas/gas-fees.mdx Outdated Show resolved Hide resolved
docs/developers/guides/gas/gas-fees.mdx Outdated Show resolved Hide resolved
docs/developers/guides/gas/gas-fees.mdx Outdated Show resolved Hide resolved
@jlwllmr jlwllmr merged commit e55b992 into main Sep 9, 2024
9 checks passed
@jlwllmr jlwllmr deleted the gas-estimation-fix-5 branch September 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide more information on estimation transaction costs
4 participants