Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

300 doc pado #301

Closed
wants to merge 2 commits into from
Closed

300 doc pado #301

wants to merge 2 commits into from

Conversation

xiafubiao
Copy link
Contributor

Add PADO to doc/tooling and infrastructure/attestation, with a created new category "Attestation", fixes #300

@vercel
Copy link

vercel bot commented Sep 22, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 22, 2023 2:02pm

emilyJLin95
emilyJLin95 suggested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@emilyJLin95 emilyJLin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi can you remove the package-lock.json change?

Can you also run npm run lint and edit project-words.txt to allowlist new words

Also just npm run build to make sure everything is building correctly?

emilyJLin95
emilyJLin95 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@emilyJLin95 emilyJLin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add these words the project-words.txt and run npm lint to make sure the lint passes

/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:2:8 - Unknown word (PADO)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:5:4 - Unknown word (PADO)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:7:2 - Unknown word (PADO)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:7:124 - Unknown word (PADO)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:9:29 - Unknown word (PADO)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:21:110 - Unknown word (PADO's)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:26:54 - Unknown word (Verax)
/home/runner/work/doc.zk-evm/doc.zk-evm/docs/build-on-linea/tooling/attestations/PADO.md:26:283 - Unknown word (Verax)

docs/build-on-linea/tooling/attestations/PADO.md
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xiafubiao can you rename PADO.md to pado.md? The build is failing

package-lock.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you remove this file from the commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Emily, thx for the review, I fixed the issues (the package-lock.json issue, and the lint pass issue) and have now created a new PR in another thread. sorry for the late reply due to the holidays

@xiafubiao xiafubiao closed this Oct 19, 2023
@xiafubiao
Copy link
Contributor Author

I created a new PR in the new link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyJLin95 emilyJLin95 emilyJLin95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PADO to Linea doc in Tooling & Infra section
2 participants
@xiafubiao @emilyJLin95