fix: Rework ifs transform
#245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds several test cases which illustrate problems with if conditions.
This replaces these functions with `lower_expr()` which more closely follows the Go implementation. Currently, this is passing all tests but needs more work to be sure. A few points: * Need to remove the now redundant code. * Need to better manage optimisation of constant expressions. The problem with the latter is that we probably need to do the constant evaluation at the point of an `if` condition.
This removes the old implementation, and applies some (relatively simple) optimisation to remain consistent with the original corset.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks the
ifstransform to use a simpler approach which should be easier to understand and maintain. Following the originalcorsetimplementation, this applies some optimisations in various cases.