Fix: Incorrect Handling of Perspective Selectors #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal here is to improve the mechanism for raising `lists` out of expressions.
This puts through a fairly invasive change to the way that `if` and `lists` are expanded. Specifically, `lists` are now explicitly "compiled out" and raised to the very top. This means that subsequent code which assumes lists are only ever at the top will work correctly.
This removes some chunks of deadcode, and fixes a number of linting errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that lists were not being raised correctly out of expressions and, in particular, this was causing a problem with perspective selectors.