Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs for built-in processors, improve filterfield processor #992

Merged
merged 8 commits into from
Apr 11, 2023
Merged

Update docs for built-in processors, improve filterfield processor #992

merged 8 commits into from
Apr 11, 2023

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Apr 9, 2023 •
edited
Loading

Description

  1. The docs for a few processors mention how they handle raw data with or without schemas. In some of those cases, the code clearly shows that raw data isn't supported at all. I believe the comments were made to show how the processors would behave with schemas. This PR updates the docs to show how the processors currently behave.
  2. filterfield processors use a function that panics if the input cannot be parsed. This PR uses a different function which returns an error.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso changed the title Docs for the timestampconvertor processors Update docs for built-in processors Apr 9, 2023
@hariso hariso changed the title Update docs for built-in processors Update docs for built-in processors, improve filterfield processor Apr 9, 2023
@hariso hariso marked this pull request as ready for review April 9, 2023 15:46
@hariso hariso requested a review from a team as a code owner April 9, 2023 15:46
@hariso hariso enabled auto-merge (squash) April 9, 2023 15:58
lovromazgon
lovromazgon approved these changes Apr 11, 2023
View reviewed changes
Copy link
Member

@lovromazgon lovromazgon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We should rename the timestamp converter processor in the docs PR.

@hariso
Copy link
Contributor Author

hariso commented Apr 11, 2023

+1 We should rename the timestamp converter processor in the docs PR.

Good callout!

@hariso hariso merged commit 9541533 into main Apr 11, 2023
@hariso hariso deleted the haris/docs branch April 11, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovromazgon lovromazgon lovromazgon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @lovromazgon