create both deb and rpm files when releasing

[maha-hajja]

Description

reference to nfpm: https://nfpm.goreleaser.com/configuration/

tested on a conduit fork https://github.com/ConduitIO/conduit-maha/releases/tag/v0.3.0

you can test installing it using docker:

sudo docker pull ubuntu # get the docker image
sudo docker run -ti --rm ubuntu /bin/bash # run it
apt update
apt-get install wget
apt-get install dpkg
wget https://github.com/ConduitIO/conduit-maha/releases/download/v0.3.0/conduit-maha_0.3.0_linux_amd64.deb
dpkg -i conduit-maha_0.3.0_linux_amd64.deb
apt update
apt install conduit-maha # will be only "conduit" for this repo
conduit # try running conduit!

Related to #824

Quick checks:

• I have followed the Code Guidelines.
• There is no other pull request for the same update/change.
• I have written unit tests.
• I have made sure that the PR is of reasonable size and can be easily reviewed.

[hariso]

Great work!

conduit # try running conduit!

A thought: it might be good to run Conduit as a systemd service: https://docs.conduit.io/docs/Deploy/aws_ec2/#add-conduit-to-systemd-and-start-it

[maha-hajja]

@hariso true! but it's up to the user tbh, we can suggest that way in the installation documentation (when we add them) and mention why they're better

[hariso]

@hariso true! but it's up to the user tbh, we can suggest that way in the installation documentation (when we add them) and mention why they're better

@maha-hajja That certainly is an option. I'm under impression that Conduit would be something that would run as a service. Otherwise, it makes the Debian package almost no different than running the Conduit binary.

[lovromazgon]

@maha-hajja I see that the created filenames contain the suffix _linux_386, _linux_amd64 and _linux_arm64. Is it possible to rename those to _Linux_i386, _Linux_x86_64 and _Linux_arm64 respectively? This way we would keep the naming consistent with the other assets that are produced in a release.

[hariso]

@maha-hajja I see that the created filenames contain the suffix _linux_386, _linux_amd64 and _linux_arm64. Is it possible to rename those to _linux_i386, _linux_x86_64 and _linux_arm64 respectively (the last one is actually correct already)? This way we would keep the naming consistent with the other assets that are produced in a release.

Good callout for the names! 👍 It maybe even makes sense to drop linux completely (if that's not too much messing with the configs).

[lovromazgon]

I would leave linux in there for consistency, also for example Go uses go1.20.1.windows-amd64.msi, even though .msi already tells you it's for windows.

[maha-hajja]

@lovromazgon done! added a name template for nfpms, tested on https://github.com/ConduitIO/conduit-maha/releases/tag/v0.5.1