Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent pipeline service rerunning already failed pipeline. #2009

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

AdamHaffar
Copy link
Contributor

@AdamHaffar AdamHaffar commented Dec 11, 2024

Description

Prevents pipeline service from rerunning a pipeline that the provisioning service has already tried and failed to run by setting its status to pipeline.StatusDegraded.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@AdamHaffar AdamHaffar requested a review from a team as a code owner December 11, 2024 18:17
@AdamHaffar AdamHaffar requested a review from hariso December 11, 2024 18:17
@AdamHaffar AdamHaffar added the bug Something isn't working label Dec 11, 2024
pkg/lifecycle/service.go Outdated Show resolved Hide resolved
@AdamHaffar AdamHaffar changed the title Ensure correct pipeline clean-up from invalid node in config file. Prevent pipeline service rerunning already failed pipeline. Prevent pipeline service rerunning already failed pipeline. Jan 14, 2025
@@ -431,6 +431,7 @@ func (s *Service) buildRunnablePipeline(
) (*runnablePipeline, error) {
nodes, err := s.buildNodes(ctx, pl)
if err != nil {
pl.SetStatus(pipeline.StatusDegraded)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we would change the status, if we didn't even start the pipeline yet? 🤔 Is there an issue connected to this PR that describes what problem we're trying to solve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants