Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a connector's or processor's plugin name to be updated #1938

Merged
merged 9 commits into from
Nov 8, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Nov 1, 2024

Description

Fixes #1929.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed. -- Most changes are boring propagations of the plugin argument.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

The latest Buf updates on your PR. Results from workflow buf-validate / validate (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedNov 8, 2024, 2:30 PM

@hariso hariso marked this pull request as ready for review November 1, 2024 17:34
@hariso hariso requested a review from a team as a code owner November 1, 2024 17:34
@hariso hariso changed the title Allow a connector's plugin name to be updated Allow a connector's or processor's plugin name to be updated Nov 4, 2024
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through this pull-request with @hariso and made perfect sense to me. Great work.

proto/buf.yaml Show resolved Hide resolved
@raulb raulb enabled auto-merge (squash) November 8, 2024 14:31
@raulb raulb merged commit 977b037 into main Nov 8, 2024
4 checks passed
@raulb raulb deleted the haris/relaxed-plugins branch November 8, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Upgrade plugin in an existing pipeline
2 participants