Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: race condition for force stop #1909

Merged
merged 2 commits into from
Oct 11, 2024
Merged

fix: race condition for force stop #1909

merged 2 commits into from
Oct 11, 2024

Conversation

raulb
Copy link
Member

@raulb raulb commented Oct 11, 2024 •
edited
Loading

Description

Fixes #1891

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • have made sure that the PR is of reasonable size and can be easily reviewed.

@raulb @hariso
adds a mutex to ctx cancel
075d01a 
Co-Authored-By: Haris Osmanagić <[email protected]>
@raulb raulb requested a review from a team as a code owner October 11, 2024 08:54
@raulb raulb merged commit dba04d5 into main Oct 11, 2024
3 checks passed
@raulb raulb deleted the raul/fix-flaky-test branch October 11, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hariso hariso hariso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Fix flaky test
2 participants
@raulb @hariso