Handle concurrent access to a pipeline's status field #1794
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1778.
The approach that we initially planned didn't quite work and was changed to use a
sync.Mutex
because of following:atomic
is sub-optimal user experience because it forces the user to work with the low-level constructs. In other words we should either expose a field or methods that work with just thepipeline.Status
field.myPipeline.Status = atomic.Pointer{}
atomic.Pointer
would involve a few steps:For the reasons above, this PR uses a
sync.Mutex
and adds a getter and setter method for the status field, that is now unexported.Quick checks