[UI] Add synchronous start/stop pipeline error notifications #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UI test coverage: 69.89% 🚨 Decreased by -0.21% (was 70.1%) |
jayjayjpg
reviewed
Jan 27, 2022
jmar910
force-pushed
the
james/add-sync-start-stop-errors
branch
from
9aaeac5 to
ff4dc5d
Compare
|
UI test coverage: 70.61% 🎉 Increased by +0.51% (was 70.1%) |
jayjayjpg
approved these changes
Jan 27, 2022
| async stopPipeline(pipeline) { | ||
| await pipeline.stopPipeline(); | ||
| try { | ||
| await pipeline.stopPipeline(); |
| await click(page.pipelineStatusStop); | ||
| }); | ||
|
|
||
| test('it displays an error notification', function (assert) { |
There was a problem hiding this comment.
Nice testing addition! ✨
jmar910
force-pushed
the
james/add-sync-start-stop-errors
branch
from
ff4dc5d to
de3f4b5
Compare
|
UI test coverage: 70.61% 🎉 Increased by +0.51% (was 70.1%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We wrote an error system around handling asynchronous pipeline errors, but it doesnt handle synchronous pipeline errors 😅
This PR addresses that
Fixes #127
Quick checks: