[Perf] Lazy encode connectors in persister #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nassor
approved these changes
Oct 24, 2023
|
I didn't have time at this point to create benchmarks for this, but rest assured, I tested it manually and there was about a 7% increase in throughput 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With this change the connector persister lazily encodes connectors only when they are flushed. The connector data is still copied at the time the connector requests to be persisted. This is currently required because of the locking mechanism (see #857 for more info), there is still room for improvement here as most copies will be thrown away, especially on fast pipelines.
This also changes the library used for encoding to github.com/goccy/go-json, which is quite a lot faster.
Quick checks: