Remove Assert Package 3/3

[AdamHaffar]

Description

Refactor all _test.go that used pkg/foundation/assert to use (https://github.com/matryer/is) in the following packages:

PR (1/3)

• ./pipeline
• ./record
• ./conduit
• ./web

PR (2/3)

• ./processor
• ./orchestrator

PR (3/3)

• ./foundation

Partially Fixes #260

Quick checks:

• I have followed the Code Guidelines.
• There is no other pull request for the same update/change.
• I have written unit tests. Can you even write tests for tests :o
• I have made sure that the PR is of reasonable size and can be easily reviewed.

[maha-hajja]

since this is the last PR to remove the assert package, let's add the package name to the depguard linter for golangci-lint, to make sure no other file will have it in the future

conduit/.golangci.yml

Line 7 in 31e283d

depguard:

[lovromazgon]

Why don't we just remove the package itself? Then there's nothing to import, nothing to guard against 🙂

[maha-hajja]

@lovromazgon lol totally forgot that we're the ones who created it, let's do what he said 🤣