don't create slices in enrich

ConduitIO · Apr 3, 2023 · 99148d8 · 99148d8
1 parent 1637cba
commit 99148d8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/pkg/provisioning/config/enrich.go b/pkg/provisioning/config/enrich.go
@@ -54,6 +54,9 @@ func enrichDLQ(dlq DLQ) DLQ {
 
 // enrichConnectors sets default values for connectors config fields
 func enrichConnectors(mp []Connector, pipelineID string) []Connector {
+	if mp == nil {
+		return nil
+	}
 	out := make([]Connector, len(mp))
 	for i, cfg := range mp {
 		if cfg.Name == "" {
@@ -69,6 +72,9 @@ func enrichConnectors(mp []Connector, pipelineID string) []Connector {
 
 // enrichProcessorsConfig sets default values for processors config fields
 func enrichProcessors(mp []Processor, parentID string) []Processor {
+	if mp == nil {
+		return nil
+	}
 	out := make([]Processor, len(mp))
 	for i, cfg := range mp {
 		if cfg.Workers == 0 {

diff --git a/pkg/provisioning/config/enrich_test.go b/pkg/provisioning/config/enrich_test.go
@@ -124,8 +124,8 @@ func TestEnrich_DefaultValues(t *testing.T) {
 				WindowSize:          &pipeline.DefaultDLQ.WindowSize,
 				WindowNackThreshold: &pipeline.DefaultDLQ.WindowNackThreshold,
 			},
-			Connectors: []Connector{},
-			Processors: []Processor{},
+			Connectors: nil,
+			Processors: nil,
 		},
 	}}
 

diff --git a/pkg/provisioning/service_test.go b/pkg/provisioning/service_test.go
@@ -67,7 +67,7 @@ var (
 		Plugin:     "builtin:file",
 		PipelineID: oldPipelineInstance.ID,
 		Config: connector.Config{
-			Name:     "source",
+			Name:     "source-new",
 			Settings: map[string]string{"path": "my/path/file1.txt"},
 		},
 	}