Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specgen: Order fields (required first, then by name alphabetically) #224

Merged
merged 4 commits into from
Dec 19, 2024
Merged

specgen: Order fields (required first, then by name alphabetically) #224

merged 4 commits into from
Dec 19, 2024

Conversation

hariso
Copy link
Contributor

@hariso hariso commented Dec 16, 2024 •
edited
Loading

Description

Closes #209.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@hariso hariso requested a review from a team as a code owner December 16, 2024 15:30
raulb
raulb approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@raulb raulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one minor suggestion. Looks good anyways

specgen/specgen/model/v1/model_test.go Outdated Show resolved Hide resolved
@hariso hariso merged commit 0ae99ed into specgen Dec 19, 2024
3 checks passed
@hariso hariso deleted the haris/specgen-order-parameters branch December 19, 2024 17:07
@hariso hariso mentioned this pull request Dec 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raulb raulb raulb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hariso @raulb