Development to main #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TOR-72/synchronizations-test-endpoint
…tions-test-endpoint' into feature/CONNECTOR-62/synchronization-pagination
…TOR-62/synchronization-pagination
…s-based-on-loging
…ervice Frontend still need to be implemented
…s-based-on-loging
…tion-pagination' into fix/small-fixes-based-on-loging
…t' into fix/small-fixes-based-on-loging
…tion-pagination' into fix/small-fixes-based-on-loging
fixed mapping test cast and made it optional
hotfix synchronization modal
RalkeyOfficial
approved these changes
Nov 8, 2024
|
Approved |
bbrands02
approved these changes
Nov 8, 2024
rjzondervan
requested changes
Nov 8, 2024
| @@ -194,8 +194,8 @@ public function changeSchema(IOutput $output, Closure $schemaClosure, array $opt | |||
| $table->addColumn('version', Types::STRING, ['notnull' => true, 'length' => 255, 'default' => '0.0.1']); | |||
| $table->addColumn('synchronization_id', Types::STRING, ['notnull' => true, 'length' => 255]); | |||
| // Source | |||
| $table->addColumn('source_id', Types::STRING, ['notnull' => false, 'length' => 255]); | |||
| $table->addColumn('source_hash', Types::STRING, ['notnull' => false, 'length' => 255]); | |||
| $table->addColumn('origin_id', Types::STRING, ['notnull' => false, 'length' => 255]); | |||
There was a problem hiding this comment.
We're not updating migrations that have already been merged to main. This will have to be fixed otherwise.
…-consumer-console-error fixed console error
…g-test-result-looks feature/CONNECTOR-121/mapping-test-result-looks
Keep old properties
Fix migrations for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.