Fixing most of the synchronysation related stuf #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TOR-72/synchronizations-test-endpoint
…tions-test-endpoint' into feature/CONNECTOR-62/synchronization-pagination
…TOR-62/synchronization-pagination
…s-based-on-loging
…ervice Frontend still need to be implemented
…s-based-on-loging
…tion-pagination' into fix/small-fixes-based-on-loging
…t' into fix/small-fixes-based-on-loging
WilcoLouwerse
requested changes
Nov 5, 2024
| */ | ||
| public function synchronize(Synchronization $synchronization): array | ||
| public function synchronize(Synchronization $synchronization, ?bool $isTest = false): array |
There was a problem hiding this comment.
Grote functie, zou deze makkelijk/snel nog wat ingekort kunnen worden?
There was a problem hiding this comment.
Ja maar dat was die al, en functie clean up is natuurlijk geen onderdeel van de fix ;)
There was a problem hiding this comment.
Oke, prima voor nu, maar moeten we dan nog wel een andere keer naar kijken
rjzondervan
requested changes
Nov 5, 2024
|
Okay, seems I have found the issue that happened on my first try. Remains the FE issue |
…tion-pagination' into fix/small-fixes-based-on-loging
… into fix/small-fixes-based-on-loging
…s-based-on-loging
rjzondervan
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.