Suspend resume configure baker #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
from
90201e3
to
c71d9f1
Compare
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
7 times, most recently
from
6071626
to
469efc9
Compare
td202
requested changes
Sep 23, 2024
concordium-consensus/src/Concordium/GlobalState/Basic/BlockState/Account.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/Account/StructureV1.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/Bakers.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
5 times, most recently
from
06b6beb
to
5b01592
Compare
drsk0
commented
Sep 27, 2024
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
11 times, most recently
from
d91a51d
to
14e2c48
Compare
drsk0
commented
Sep 27, 2024
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
…ount.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]>
…ount/StructureV1.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]>
In favour of functions like getBaker/getAccountBaker.
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
from
14e2c48
to
c4b93dd
Compare
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
from
c4b93dd
to
90bc4c0
Compare
td202
approved these changes
Oct 16, 2024
concordium-consensus/src/Concordium/GlobalState/Persistent/Account/StructureV1.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Persistent/BlockState.hs
Show resolved
Hide resolved
concordium-consensus/src/Concordium/GlobalState/Basic/BlockState/Account.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/ProtocolUpdate/P8/Reboot.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/src/Concordium/ProtocolUpdate/P8/Reboot.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/globalstate/GlobalStateTests/ConfigureValidator.hs
Outdated
Show resolved
Hide resolved
concordium-consensus/tests/scheduler/SchedulerTests/ConfigureBaker.hs
Outdated
Show resolved
Hide resolved
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
…ount/StructureV1.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
Co-authored-by: Thomas Dinsdale-Young <[email protected]>
…ount/StructureV1.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]>
…ckState.hs Co-authored-by: Thomas Dinsdale-Young <[email protected]>
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
2 times, most recently
from
9359127
to
0eda6ae
Compare
drsk0
force-pushed
the
suspend_resume_configure_baker
branch
from
0eda6ae
to
be864c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
suspendfield to theBakerConfigureUpdatein the consensus and adds the necessary logic to set/unset the corresponding field. This comes (unfortunately) with more necessary boilerplate code. I haven't found already present tests that could be extended for this.Fixes #1225.
Checklist
hard-to-understand areas.
CLA acceptance
By submitting the contribution I accept the terms and conditions of the
Contributor License Agreement v1.0
link: https://developers.concordium.com/CLAs/Contributor-License-Agreement-v1.0.pdf
I accept the above linked CLA.