-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function for stringifying wrapper types as unwrapped, serializable types #306
Conversation
Kept as draft until it's been verified as compatible in Concordium/concordium-dapp-libraries#51 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes do break with the browser wallet, using this with wCCD, gives me
Error: The given transaction is not valid due to: TypeError: Cannot read properties of undefined (reading 'split').
I'll check wallet connect tomorrow.
Upon checking again it seems you're right.. Will need to figure out an alternative |
21af1cf
to
ad02b6e
Compare
e736e30
to
4a81379
Compare
Purpose
Unwrap types to a representation of the inner value, to make it easier to stringify structures using the newly added types into something sensible (f.x. for http requests).
Types that already had
toJSON
functions on them are kept as is.Changes
toJSON
functions where needed.Checklist
hard-to-understand areas.