[BRO-39] Migrate away from injecting API (Draft example of chrome API) #477
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example of forwarding requests to walletApi with Proxy
The general concept of this example is quite simple
In api-helper
We need a proxy with an empty object of WalletApi type
new Proxy({} as WalletApi, proxyHandler)
This enables TS annotations
And we can intercept all requests and forward them through the chrome API
With
chrome.runtime.sendMessage
In background.js
With
chrome.runtime.onMessageExternal
listen to this requestsMain difficulty I encountered is the inability to simply import the walletApi.
A new class needs to be created, which in turn requires many additional changes to BW.
In this case, it looks like a lot of risky changes.