Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extra details #338

Merged
merged 8 commits into from
Aug 17, 2023
Merged

Extra details #338

merged 8 commits into from
Aug 17, 2023

Conversation

orhoj
Copy link
Contributor

@orhoj orhoj commented Aug 16, 2023

Purpose

Add a button for showing "extra details" about a credential, i.e. non-attribute information.

Changes

  • Added details button to more menu for credentials in the details view.
  • Adjusted popup menu component to support what's needed.

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

Base automatically changed from revoke-credentials to feature/web3-id August 17, 2023 13:28
@orhoj orhoj merged commit a0eb36e into feature/web3-id Aug 17, 2023
4 checks passed
@orhoj orhoj deleted the extra-details branch August 17, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shjortConcordium shjortConcordium shjortConcordium approved these changes

Assignees

@orhoj orhoj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orhoj @shjortConcordium