Move compilation target from concordium_base/cargo.toml
to Setup.hs
#559
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To avoid conflicts when compiling dependants on
concordium_base
, this proposal moves the compilation target specification from theconcordium_base
crate to the compilation done by the haskell dependant.One instance where a conflict occurs is, if
concordium_base
is used as both a dependency inbuild.rs
andsrc/*.rs
. In./mobile_wallet
this was worked around by aligning the profile used forbuild.rs
with the one used forsrc/lib.rs
, however this was not a feasible solution in another project and is hard for other developers to debug if they use this in a similar fashion.I don't know if this should be marked as a change in the changelog or not?
Checklist
hard-to-understand areas.