Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move compilation target from concordium_base/cargo.toml to Setup.hs #559

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

soerenbf
Copy link
Contributor

Purpose

To avoid conflicts when compiling dependants on concordium_base, this proposal moves the compilation target specification from the concordium_base crate to the compilation done by the haskell dependant.

One instance where a conflict occurs is, if concordium_base is used as both a dependency in build.rs and src/*.rs. In ./mobile_wallet this was worked around by aligning the profile used for build.rs with the one used for src/lib.rs, however this was not a feasible solution in another project and is hard for other developers to debug if they use this in a similar fashion.

I don't know if this should be marked as a change in the changelog or not?

Checklist

  • My code follows the style of this project.
  • The code compiles without warnings.
  • I have performed a self-review of the changes.
  • I have documented my code, in particular the intent of the
    hard-to-understand areas.
  • (If necessary) I have updated the CHANGELOG.

to avoid imposing restrictions on rust dependants
Setup.hs Outdated Show resolved Hide resolved
Setup.hs Outdated Show resolved Hide resolved
Setup.hs Outdated Show resolved Hide resolved
@soerenbf soerenbf requested a review from td202 November 4, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants