Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Contributors page #27

Merged
merged 4 commits into from
Mar 14, 2023

Conversation

wilsonmcdade
Copy link
Collaborator

#19

Copy link
Member

@asimonson1125 asimonson1125 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Styling the user boxes can wait, but we should probably do a quick scan of the group for links to add. Off the top of my head:
asimonson.com
noahemke.com (offline?)
https://esoccoli.me/
Not critical, but I'd have liked to see a JSON contributors list which is called and iterated over to generate the email hashes. If the emails might be displayed elsewhere, hashing could be deferred to the html template to get the profile pictures of everyone involved in a single line.

@wilsonmcdade
Copy link
Collaborator Author

Agree about waiting on box styling. Since we're just using game cards, that can be done whenever game cards are updated.

I added some of the personal sites, some ppl haven't gotten back with me with their website.

I'd love to see this feature worked into the api or at least have some user-editable fields for this, but that requires some more planning

Copy link
Collaborator

@MTFT-Games MTFT-Games left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me so far

@wilsonmcdade wilsonmcdade merged commit 5959842 into ComputerScienceHouse:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants