minor cleanup in get_source_tarball_from_git + add & use remove_dir/remove function + add tests #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use the golf toolchain within goolf-1.4.10, also added.
This PR replaces easybuilders#2234. subtoolchains are now searched using a breadth-first-search, which allows multiple subtoolchains per toolchain. Some subtoolchains such as golf and golfc are now marked OPTIONAL since they do not have to exist as modules, and can be skipped. Since those optional subtoolchains cannot usually be found via a dependency search (as toolchain easyconfigs do not typically have subtoolchains as dependencies) try to search for subtoolchain/version with the same version as the parent. E.g. goolfc/2.6.10 searches for golfc/2.6.10, and golfc/2.6.10 searches for golf/2.6.10 and gcccuda/2.6.10.
sync with master & bump version to 3.6.3dev
This fixes easybuilders#2522 for me, on a new enough CentOS 6 with these packages installed: python-requests-2.6.0-4.el6.noarch pyOpenSSL-0.13.1-2.el6.x86_64
…heck skip checksum check for extensions that are specified only by name
…lues in EasyConfig.dump
prefer templates with shortest 'key' in case of duplicate template values in EasyConfig.dump
add support to bootstrap script to force install specific EasyBuild version
Use namelower as default for github_account
take into account dependency 'wrappers' in check_conflicts
…emove function + add tests
|
That prevents me from merging this branch back into computecanada-master. Not merging. Trying to figure out how to resolve the conflict with upstream develop... probably going to end up creating a new PR and closing this one. |
mboisson
pushed a commit
that referenced
this pull request
Nov 20, 2018
fix some more style issues in test/framework/suite.py
bartoldeman
pushed a commit
that referenced
this pull request
Nov 28, 2018
tweak existing toy easyconfig in test_easyconfig_optarch_flags rather than adding two new test easyconfigs with just a different value for toolchainopts
bartoldeman
pushed a commit
that referenced
this pull request
Sep 6, 2019
each entry in checksums may in turn be a list of different types of checksums
mboisson
pushed a commit
that referenced
this pull request
Apr 14, 2020
fixes, cleanup, enhancements and tests for probing external modules for missing metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mboisson This should make easybuilders#2555 good to go...