Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize BFGS for spinel #2

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

albert-de-montserrat
Copy link

Optimizes BFGS for the spinel case. I see a speed up of ~30/40% on my machine.

Main branch:

julia> @be null_min_BFGS!($gv,$ph,$gm)
Benchmark: 3173 samples with 22 evaluations
 min    1.291 μs
 median 1.305 μs
 mean   1.310 μs
 max    2.350 μs

This PR:

julia> @be null_min_BFGS!($gv,$ph,$gm)
Benchmark: 2762 samples with 33 evaluations
 min    872.727 ns
 median 881.818 ns
 mean   884.147 ns
 max    1.621 μs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant