Sliced writing fixes #4887
Merged
Sliced writing fixes #4887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychocoderHPC
added
bug
franzpoeschel
force-pushed
the
sliced-writing-fixes
branch
from
25cf470
to
181ee0b
Compare
|
I now added a workaround to forcibly mark the iteration dirty. This ensures that things are flushed when they should. |
psychocoderHPC
previously approved these changes
Apr 29, 2024
psychocoderHPC
force-pushed
the
sliced-writing-fixes
branch
from
181ee0b
to
9ada368
Compare
|
I rebased this PR |
psychocoderHPC
approved these changes
Apr 30, 2024
psychocoderHPC
merged commit 2814768
into
ComputationalRadiationPhysics:dev
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of sliced writing re-initializes the components over and over again for each component. For the attributes, that's just duplicate work, but additionally the array sizes get "changed" over and over again (to the same size as before). This might lead to trouble in backends that have restricted support for extensible arrays.
HOWEVER, this PR runs into a bug on the current dev branch of the openPMD-api, probably introduced by openPMD/openPMD-api#1598 and fixed by openPMD/openPMD-api#1615. Will need to do more testing to confirm this. The latest release seems unaffected, but please don't merge just yet.
Apart from this, to workaround another parallel flushing bug that René discovered, I should probably work sth in to make the iteration artificially dirty anyway.