Topic cleanup particle interpolation interface #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change interface of FieldToParticleInterpoaltion* - change interface for ShiftCoordinateSystem* Both classes has a one to one relation and can't combined with other methods, this it use better to cleanup the template interface to avoid wrong usage.
|
sounds reasonable :) |
ax3l
added a commit
that referenced
this pull request
Apr 3, 2014
…rpolationInterface Topic cleanup particle interpolation interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change interface of FieldToParticleInterpolation because we have a one to one relation between FieldToParticleInterpolation and ShiftCoordinateSystem.
e.g. FieldToParticleInterpolationNative can only use ChargeAssignment as function from particle shape.