-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: better help text #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to 99db21e in 2 minutes and 48 seconds
More details
- Looked at
476
lines of code in11
files - Skipped
0
files when reviewing. - Skipped posting
0
drafted comments based on config settings.
Workflow ID: wflow_YInN3hEQz1pgjGOt
Want Ellipsis to fix these issues? Tag @ellipsis-dev
in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on ff63d49 in 1 minute and 39 seconds
More details
- Looked at
15
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. composio/cli/__init__.py:26
- Draft comment:
The example commandcomposio add github
is described as adding an integration to the user's account. Ensure that the command functionality aligns with this description. If the command does something different, the help text should be updated to reflect the actual functionality. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_lOxNaUdqntOFeyEL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
/review |
PR Review 🔍
Code feedback:
|
Check out the code feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on f5e6e88 in 1 minute and 6 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. composio/cli/login.py:19
- Draft comment:
The correction in the example usage from 'composio login2' to 'composio login' is appropriate and aligns with the actual command. This change helps avoid confusion and improves the clarity of the help text. - Reason this comment was not posted:
Confidence changes required:0%
The PR description mentions that the help text for thecomposio login
command has been updated. The diff shows a correction in the example usage from 'composio login2' to 'composio login'. This is a necessary fix as 'composio login2' does not exist and would confuse users. The rest of the code in login.py seems to be unchanged and related to the functionality of the login command itself, which is not the focus of this PR. The help text changes are correctly reflected in the examples provided in the classExamples
.
Workflow ID: wflow_tc9XnAqOTa0nUs78
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
@sohamganatra Had checked. We're ovverriding the click and following patterns of it.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 01f68c1 in 2 minutes and 7 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. composio/cli/utils/helpfulcmd.py:13
- Draft comment:
Thehelp
attribute is initialized toNone
and not modified anywhere withinHelpfulCmdBase
or its subclasses. Ensure that this attribute is properly set in subclasses or during instances creation to utilize the enhanced help text functionality effectively. - Reason this comment was not posted:
Confidence of 0% on close inspection, compared to threshold of 50%.
Workflow ID: wflow_Issy1mkZhJJXRXiP
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
⌛ 3 days left in your free trial, upgrade for $20/seat/month or contact us.
Summary:
This PR enhances the help text, formatting, and command descriptions across various CLI commands in the Composio project, with specific updates to
composio/cli/__init__.py
and improvements in command descriptions.Key points:
HelpfulCmdBase
.composio/cli/__init__.py
.format_help
inRichGroup
class.composio add github
andcomposio login
commands.composio/cli/login.py
.Generated with ❤️ by ellipsis.dev