fix: avoid duplicate input in basic auth

[tushar-composio]

_collect_input_fields takes user input, we should only be calling it once.

---

Important

Fix duplicate input collection in _handle_basic_auth by reusing auth_config in add.py.

• Behavior:
  • In _handle_basic_auth in add.py, _collect_input_fields is now called once and its result is reused for auth_config and field_inputs.
• Functions:
  • _handle_basic_auth now stores the result of _collect_input_fields in auth_config and reuses it, preventing duplicate input collection.

^{This description was created by for db48d78. It will automatically update as commits are pushed.}

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
composio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 23, 2024 7:06am

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to db48d78 in 16 seconds

More details

• Looked at 32 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. python/composio/cli/add.py:328

• Draft comment:
  The docstring for _collect_input_fields is incomplete. Consider providing a more detailed description of the function's purpose and parameters.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR correctly refactors the code to avoid duplicate calls to _collect_input_fields. However, the docstring for _collect_input_fields is incomplete and should be improved for clarity.

Workflow ID: wflow_iG6x8XuBbTWMirbB

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[shreysingla11]

Code Review Summary

Changes Overview

• ✅ Fixed duplicate user input prompts in basic authentication flow
• ✅ Improved code efficiency by storing and reusing collected input
• ✅ Better user experience by asking for authentication information only once

Code Quality: 8/10

Strengths:

• Clean and focused changes
• Follows DRY principles
• Improves user experience
• Maintains code readability

Suggestions for Future:

1. Enhance docstrings for better code documentation
2. Consider adding more robust input validation
3. Make type hints more specific in related functions

Overall, this is a well-implemented fix that solves a real user experience issue. The changes are minimal, focused, and safe to merge. 👍

[github-actions]

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11985143528/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11985143528/html-report/report.html