-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add proxy support for executing custom actions #877
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on e94e0dd in 22 seconds
More details
- Looked at
11
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/src/sdk/models/Entity.ts:302
- Draft comment:
Add a newline at the end of the file for POSIX compliance. - Reason this comment was not posted:
Confidence changes required:10%
The file lacks a newline at the end, which is a common best practice for POSIX compliance and avoiding potential issues with some tools.
Workflow ID: wflow_4JTbBobUGl3eacUv
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to e66ea3c in 1 minute and 50 seconds
More details
- Looked at
1235
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
4
drafted comments based on config settings.
1. js/src/sdk/models/actions.ts:254
- Draft comment:
Ensure that thedata
parameter passed toexecuteActionProxyV2
is not undefined, as the method signature inActionsService
allows for an optional parameter. - Reason this comment was not posted:
Comment did not seem useful.
2. js/src/sdk/models/actions.ts:252
- Draft comment:
Consider refactoring theexecuteRequest
method to avoid code duplication with similar methods in other classes, such asComposioToolSet
. - Reason this comment was not posted:
Marked as duplicate.
3. js/src/sdk/base.toolset.ts:281
- Draft comment:
Consider refactoring theexecuteRequest
method to avoid code duplication with similar methods in other classes, such asActions
. - Reason this comment was not posted:
Marked as duplicate.
4. js/src/sdk/base.toolset.ts:285
-
Draft comment:
This appears to be a duplicate implementation of the action proxy request execution. -
method
executeRequest
(actions.ts) -
Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment claims duplication, but without full context ofactions.ts
, it's speculative. The evidence shows a similar call, but doesn't confirm duplication. The comment might be speculative unless there's strong evidence of redundancy.
The evidence provided is limited and doesn't conclusively prove duplication. The methods might have different contexts or purposes, which isn't clear from the snippet.
Without full context, it's difficult to confirm duplication. The comment might be speculative, and the evidence doesn't strongly support the claim.
The comment seems speculative without strong evidence of duplication. It should be deleted unless more context is provided to confirm the claim.
Workflow ID: wflow_Tj3ApGcJ56YwY2L1
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 6417fd4 in 47 seconds
More details
- Looked at
22
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/src/sdk/client/types.gen.ts:965
- Draft comment:
The type aliasin
is still present in the code but is not used. Consider removing it to avoid confusion. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_OZvOSyjIM8jRIK5j
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
…add-proxy-config
…osio into add-proxy-config
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on 3c11cab in 19 seconds
More details
- Looked at
12
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. js/package.json:3
- Draft comment:
Ensure that the version update inpackage.json
is consistent with semantic versioning practices. If this is a bug fix or minor change, consider updating the patch version instead. - Reason this comment was not posted:
Confidence changes required:50%
The version update in package.json is consistent with the changes made in the PR.
Workflow ID: wflow_UerLhvVlq3ZP62Fs
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
Important
Add proxy support for executing custom actions with new methods, schema updates, and test cases.
executeRequest()
method inComposioToolSet
andActions
classes for executing actions via proxy.executeActionProxyV2()
inActionsService
to support direct auth execution.ActionProxyRequestConfigDTO
andActionProxyRequestMethodDTO
to define proxy request configurations.MemberInfoResDTO
andIdentifyClientResDTO
to includeprojectId
andorgId
.langchain.spec.ts
andactionRegistry.spec.ts
.langchain.spec.ts
.clientId
toprojectId
inschemas.gen.ts
.AuthService
for adding, deleting, and retrieving projects.This description was created by for 3c11cab. It will automatically update as commits are pushed.