Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxy support for executing custom actions #877

Merged
merged 15 commits into from
Nov 22, 2024

Conversation

plxity
Copy link
Contributor

@plxity plxity commented Nov 20, 2024

Important

Add proxy support for executing custom actions with new methods, schema updates, and test cases.

  • Behavior:
    • Add executeRequest() method in ComposioToolSet and Actions classes for executing actions via proxy.
    • Update executeActionProxyV2() in ActionsService to support direct auth execution.
  • Schemas:
    • Add ActionProxyRequestConfigDTO and ActionProxyRequestMethodDTO to define proxy request configurations.
    • Update MemberInfoResDTO and IdentifyClientResDTO to include projectId and orgId.
  • Tests:
    • Add tests for proxy execution in langchain.spec.ts and actionRegistry.spec.ts.
    • Add test for creating custom actions in langchain.spec.ts.
  • Misc:
    • Rename clientId to projectId in schemas.gen.ts.
    • Add project management methods in AuthService for adding, deleting, and retrieving projects.

This description was created by Ellipsis for 3c11cab. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 6:21pm

Copy link

github-actions bot commented Nov 20, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11977987746/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11977987746/html-report/report.html

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on e94e0dd in 22 seconds

More details
  • Looked at 11 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. js/src/sdk/models/Entity.ts:302
  • Draft comment:
    Add a newline at the end of the file for POSIX compliance.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The file lacks a newline at the end, which is a common best practice for POSIX compliance and avoiding potential issues with some tools.

Workflow ID: wflow_4JTbBobUGl3eacUv


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e66ea3c in 1 minute and 50 seconds

More details
  • Looked at 1235 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. js/src/sdk/models/actions.ts:254
  • Draft comment:
    Ensure that the data parameter passed to executeActionProxyV2 is not undefined, as the method signature in ActionsService allows for an optional parameter.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. js/src/sdk/models/actions.ts:252
  • Draft comment:
    Consider refactoring the executeRequest method to avoid code duplication with similar methods in other classes, such as ComposioToolSet.
  • Reason this comment was not posted:
    Marked as duplicate.
3. js/src/sdk/base.toolset.ts:281
  • Draft comment:
    Consider refactoring the executeRequest method to avoid code duplication with similar methods in other classes, such as Actions.
  • Reason this comment was not posted:
    Marked as duplicate.
4. js/src/sdk/base.toolset.ts:285
  • Draft comment:
    This appears to be a duplicate implementation of the action proxy request execution.

  • method executeRequest (actions.ts)

  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment claims duplication, but without full context of actions.ts, it's speculative. The evidence shows a similar call, but doesn't confirm duplication. The comment might be speculative unless there's strong evidence of redundancy.
    The evidence provided is limited and doesn't conclusively prove duplication. The methods might have different contexts or purposes, which isn't clear from the snippet.
    Without full context, it's difficult to confirm duplication. The comment might be speculative, and the evidence doesn't strongly support the claim.
    The comment seems speculative without strong evidence of duplication. It should be deleted unless more context is provided to confirm the claim.

Workflow ID: wflow_Tj3ApGcJ56YwY2L1


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 6417fd4 in 47 seconds

More details
  • Looked at 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. js/src/sdk/client/types.gen.ts:965
  • Draft comment:
    The type alias in is still present in the code but is not used. Consider removing it to avoid confusion.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_OZvOSyjIM8jRIK5j


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 3c11cab in 19 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. js/package.json:3
  • Draft comment:
    Ensure that the version update in package.json is consistent with semantic versioning practices. If this is a bug fix or minor change, consider updating the patch version instead.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The version update in package.json is consistent with the changes made in the PR.

Workflow ID: wflow_UerLhvVlq3ZP62Fs


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@tushar-composio tushar-composio merged commit 3e20eb7 into master Nov 22, 2024
9 checks passed
@tushar-composio tushar-composio deleted the add-proxy-config branch November 22, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants