feat: add types #842
feat: add types #842
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 0915a9c in 1 minute and 4 seconds
More details
- Looked at
343lines of code in4files - Skipped
0files when reviewing. - Skipped posting
6drafted comments based on config settings.
1. js/src/sdk/client/schemas.gen.ts:797
- Draft comment:
ChangeddisplayNametodisplay_nameto maintain consistent naming convention with snake_case. - Reason this comment was not posted:
Confidence changes required:10%
The change from camelCase to snake_case in the schemas and types is consistent and aligns with the naming convention used in the rest of the file.
2. js/src/sdk/client/schemas.gen.ts:809
- Draft comment:
ChangedexpectedFromCustomertoexpected_from_customerto maintain consistent naming convention with snake_case. - Reason this comment was not posted:
Confidence changes required:10%
The change from camelCase to snake_case in the schemas and types is consistent and aligns with the naming convention used in the rest of the file.
3. js/src/sdk/client/schemas.gen.ts:817
- Draft comment:
ChangedisSecrettois_secretto maintain consistent naming convention with snake_case. - Reason this comment was not posted:
Confidence changes required:10%
The change from camelCase to snake_case in the schemas and types is consistent and aligns with the naming convention used in the rest of the file.
4. js/src/sdk/client/types.gen.ts:574
- Draft comment:
ChangeddisplayNametodisplay_nameto maintain consistent naming convention with snake_case. - Reason this comment was not posted:
Confidence changes required:10%
The change from camelCase to snake_case in the schemas and types is consistent and aligns with the naming convention used in the rest of the file.
5. js/src/sdk/client/types.gen.ts:588
- Draft comment:
ChangedexpectedFromCustomertoexpected_from_customerto maintain consistent naming convention with snake_case. - Reason this comment was not posted:
Confidence changes required:10%
The change from camelCase to snake_case in the schemas and types is consistent and aligns with the naming convention used in the rest of the file.
6. js/src/sdk/client/types.gen.ts:592
- Draft comment:
ChangedisSecrettois_secretto maintain consistent naming convention with snake_case. - Reason this comment was not posted:
Confidence changes required:10%
The change from camelCase to snake_case in the schemas and types is consistent and aligns with the naming convention used in the rest of the file.
Workflow ID: wflow_6WJMo3SxQnuGuWZ0
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a437a8e in 42 seconds
More details
- Looked at
335lines of code in11files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/sdk/utils/error.ts:12
- Draft comment:
The error codeERROR.COMMON.API_KEY_UNAVAILABLEshould be updated toERROR.COMMON.API_KEY_INVALIDto match the changes in theERRORobject. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is pointing out a change that has already been implemented in the diff. Since the change fromAPI_KEY_UNAVAILABLEtoAPI_KEY_INVALIDis already present, the comment is redundant and not needed.
I might be missing if there are other parts of the code that still useAPI_KEY_UNAVAILABLEincorrectly, but the comment specifically refers to the change in theERRORobject, which is already done.
The comment is specifically about the change in theERRORobject, which is already reflected in the diff. Therefore, the comment is unnecessary.
The comment is redundant because the change it suggests has already been made in the diff. It should be deleted.
Workflow ID: wflow_LaCEWjncc4TuVcAg
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 4d7a76f in 22 seconds
More details
- Looked at
40lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/sdk/models/connectedAccounts.ts:74
- Draft comment:
Consider adding spaces around thedataobject for better readability.
const { integrationId, entityId = 'default', labels, data = {}, redirectUri } = payload;
- Reason this comment was not posted:
Confidence changes required:20%
Theinitiatemethod in theConnectedAccountsclass has a minor formatting issue with spacing around thedataobject. This can be improved for better readability.
Workflow ID: wflow_Qv3gDXhjESuHRyqX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 69e8fd7 in 1 minute and 4 seconds
More details
- Looked at
86lines of code in9files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_QDYGFnvKb8C1rdLV
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -0,0 +1,3 @@ | |||
| --- | |||
There was a problem hiding this comment.
The new API documentation files are missing descriptions and details about the endpoints. Consider adding information such as parameters, request body, responses, and examples to improve clarity and usability. This applies to clear-cache.mdx, get-user-info.mdx, and update-connection-data.mdx.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on bb3de9b in 1 minute and 13 seconds
More details
- Looked at
41lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_9LrXyOzLz8zRgT5R
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0355079 in 32 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/package.json:3
- Draft comment:
The version update inpackage.jsonis inconsistent with the PR description. The description mentions updating from0.2.8-4to0.2.8-5, but the file shows0.2.9-6to0.2.9-7. Please ensure the versioning is consistent. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_gPIj6O9dO2vyFzrF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 772ed13 in 1 minute and 0 seconds
More details
- Looked at
133lines of code in8files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. js/src/sdk/base.toolset.spec.ts:79
- Draft comment:
Typo: 'successfull' should be 'successful'. This typo is present in multiple files and should be corrected for consistency and correctness. - Reason this comment was not posted:
Comment was on unchanged code.
2. js/src/sdk/client/types.gen.ts:2602
- Draft comment:
Typo: 'successfull' should be 'successful'. This typo is present in multiple files and should be corrected for consistency and correctness. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_GGov9Pw8BPf6EW6W
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on c83eb17 in 31 seconds
More details
- Looked at
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/sdk/client/types.gen.ts:855
- Draft comment:
Thelabelsproperty was removed fromConnectionParamstype, but the PR description indicates it should be added. This seems like a mistake. Please verify iflabelsshould be included. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_bIe8xDHFafMwtFoK
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Enhancements include new DTO properties, field renames for consistency, version update, and improved error handling across multiple files.
labelstoConnectionWithAppData,ConnectionParams,GetConnectionsQueryDto,InitiateConnectionPayloadDto,UpdateConnectionLabelsPayloadDtoinschemas.gen.tsandtypes.gen.ts.isNewtoTriggerResponseDTOinschemas.gen.tsandtypes.gen.ts.pageandoffsettoActionsQueryDTOinschemas.gen.tsandtypes.gen.ts.CreateConnectorPayloadDTOto makeappIdoptional and addedappNameinschemas.gen.tsandtypes.gen.ts.displayNametodisplay_name,expectedFromCustomertoexpected_from_customer,isSecrettois_secretinExpectedInputFieldsDTO.updateConnectionDatamethod toConnectionsServiceinconnectedAccounts.ts.package.jsonfrom0.2.8-4to0.2.8-5.error.tswith more detailed messages and suggestions.This description was created by
for c83eb17. It will automatically update as commits are pushed.