feat: throwOnError and error message more descriptive #838
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @himanshu-dixit, here are examples of how you can ask me to improve this pull request: @Sweep Fix the CI errors. @Sweep Add unit tests for the `BackendClient` class in `backendClient.ts` to verify the new `throwOnError: true` configuration, ensuring that errors are properly thrown when API requests fail. 📖 For more information on how to use Sweep, please read our documentation. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to f560e9f in 48 seconds
More details
- Looked at
105lines of code in5files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. js/src/sdk/index.ts:47
- Draft comment:
The error codeERROR.COMMON.API_KEY_UNAVAILABLEshould be updated toERROR.COMMON.API_KEY_INVALIDto match the changes in theERRORobject. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_DllmEbZC6or2ztYJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on a152201 in 30 seconds
More details
- Looked at
57lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_53y4i4yv8gxVibwS
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 5433cbe in 47 seconds
More details
- Looked at
153lines of code in4files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_DG8gyHOjycFILdCj
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 24056d1 in 19 seconds
More details
- Looked at
22lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. python/composio/cli/add.py:94
- Draft comment:
Typo fix: Corrected 'lables' to 'labels'. Ensure similar typos are corrected elsewhere if present. - Reason this comment was not posted:
Confidence changes required:10%
The PR description mentions a change from 'lables' to 'labels', which is a typo fix. This change is correctly implemented in the code.
Workflow ID: wflow_5ZaZQEJPTBUWTOOw
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Important
Enhance error handling and logging in the SDK by adding
throwOnErrorinBackendClient, improving error messages, and logging API key usage.throwOnError: trueinBackendClientconfiguration inbackendClient.ts.API_KEY_UNAVAILABLEtoAPI_KEY_INVALIDinerror.ts.CEG.handleError()inerror.ts.Composioconstructor inindex.ts.package.jsonfrom0.2.8-4to0.2.9-3.base.toolset.tsandindex.ts.This description was created by
for 24056d1. It will automatically update as commits are pushed.