Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version warnings #837

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix version warnings #837

merged 1 commit into from
Nov 7, 2024

Conversation

angrybayblade
Copy link
Collaborator

@angrybayblade angrybayblade commented Nov 7, 2024

Important

Improves version warning mechanism in warnings.py by fetching the latest version asynchronously using threading and updating the warning message.

  • Behavior:
    • Introduces _fetch_latest_version() to fetch the latest version asynchronously using threading in warnings.py.
    • Updates create_latest_version_warning_hook() to use a thread for version fetching and join with a timeout.
    • Changes warning message to "A new major version of composio is available".
  • Misc:
    • Adds threading import to warnings.py.

This description was created by Ellipsis for 0c3f06e. It will automatically update as commits are pushed.

Copy link

vercel bot commented Nov 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 7, 2024 9:40am

Copy link

sweep-ai bot commented Nov 7, 2024

Hey @angrybayblade, here are examples of how you can ask me to improve this pull request:

@Sweep Fix the CI errors.
@Sweep Add unit tests for `_fetch_latest_version()` that cover:
1. Successful version fetching when the request returns a 200 status code
2. Handling of request failures (non-200 status codes)
3. Correct parsing of version from PyPI metadata

📖 For more information on how to use Sweep, please read our documentation.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 0c3f06e in 1 minute and 1 seconds

More details
  • Looked at 60 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_lc22QJZ46YQwsATV


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

python/composio/utils/warnings.py Show resolved Hide resolved
python/composio/utils/warnings.py Show resolved Hide resolved
Copy link

github-actions bot commented Nov 7, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11720389086/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11720389086/html-report/report.html

@angrybayblade angrybayblade merged commit 11ee747 into master Nov 7, 2024
7 of 9 checks passed
@angrybayblade angrybayblade deleted the fix/version-logging branch November 7, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants