introduce refund logic for ibc transfer if tx failed by timeout. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasrodri
reviewed
Apr 24, 2024
| @@ -378,13 +381,21 @@ func NewSimApp( | |||
|
|
|||
| app.FeeGrantKeeper = feegrantkeeper.NewKeeper(appCodec, keys[feegrant.StoreKey], app.AccountKeeper) | |||
| app.UpgradeKeeper = upgradekeeper.NewKeeper(skipUpgradeHeights, keys[upgradetypes.StoreKey], appCodec, homePath, app.BaseApp, authtypes.NewModuleAddress(govtypes.ModuleName).String()) | |||
| app.IbcTransferMiddlewareKeeper = ibctransfermiddleware.NewKeeper(appCodec, keys[ibctransfermiddlewaretypes.StoreKey], authtypes.NewModuleAddress(govtypes.ModuleName).String(), | |||
| []string{ | |||
There was a problem hiding this comment.
i think this is for setting fees. this is for testnet
There was a problem hiding this comment.
this needed to make tests build success.
There was a problem hiding this comment.
we introduce keeper to ibc hook
so we need to pass it now in tests.
this i why i added a IbcTransferMiddlewareKeeper to pass into ibc hook
blasrodri
reviewed
Apr 24, 2024
| @@ -17,24 +17,24 @@ DENOM=${2:-ppica} | |||
| # remove existing daemon | |||
| rm -rf ~/.banksy* | |||
|
|
|||
| centaurid config keyring-backend $KEYRING | |||
| centaurid config chain-id $CHAINID | |||
| picad config keyring-backend $KEYRING | |||
blasrodri
reviewed
Apr 24, 2024
|
|
||
| // calculate the percentage charge | ||
| /* | ||
| coin.Percentage is 100 that means that we charge 1/100 of the transfer amount |
There was a problem hiding this comment.
do we charge 1%? Where does this number come from?
There was a problem hiding this comment.
it is example.
we charge depends on config.
I described how it calculates.
To find a percentage fee from a new amount
kkast
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce refund logic for ibc transfer if tx failed by timeout.