feat: wasmd size increase and restricts wasmd uploads to known accounts #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzmitry-lahoda
changed the title
dzmitry-lahoda
changed the title
|
@faddat what commands to run to fix go lint issues automatically? I googled and looked into CI error, but do not see exact command to run to fix linting complaints |
dzmitry-lahoda
changed the title
blasrodri
reviewed
Dec 31, 2023
blasrodri
reviewed
Dec 31, 2023
blasrodri
approved these changes
Dec 31, 2023
|
please check why ci isn't green anymore |
the only check changed after me is linter. did not found way to lint accprdimg rules waiting for command line to do so. |
golangci-lint run ./... --fix |
|
@blasrodri need to backport the test fix from master, and eventually deprecate master. |
|
NB: @dzmitry-lahoda you get bonus points for the "rob pike" commit message |
faddat
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: better wasmd init logic as per analysis (no need to set nil and reset later)