This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Hygienic procedure macros #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunlanlege
reviewed
Sep 20, 2022
| @@ -231,18 +256,18 @@ impl State { | |||
| }); | |||
|
|
|||
| quote! { | |||
| fn verify_client_consensus_state<Ctx: ReaderContext>( | |||
| fn verify_client_consensus_state<Ctx: #crate_::core::ics26_routing::context::ReaderContext>( | |||
There was a problem hiding this comment.
This isn't going to work for downstream crates, it should be
::ibc::core::ics26_routing::context::ReaderContext
There was a problem hiding this comment.
crate_ here is an identifier of the ibc crate defined by the user so that it will work (or crate keyword in case of using the macro in the ibc crate in mocks). The only difference is that there is no prepending ::, I'll add it
There was a problem hiding this comment.
ok didn't know that, great thinking
seunlanlege
approved these changes
Sep 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #62