Refactor: Decouple *Client types from Any* types

[vmarkushin]

The basic reason for this refactor is to be able to separate different IBC clients (Beefy, Near, etc.) from the ibc-rs crate itself. This wasn't possible due to the usage of Any* (AnyClient, AnyConsensusState, etc.) types highly coupled to the particular client implementation, so in order to do this one would need to abstract the clients on some global definition of the Any* types. This is done by introducing AnyHeader, AnyClientState, etc. types in the ClientKeeper trait and passing it as a generic Ctx to most of the IBC and clients' functions.

[blasrodri]

does chain id change every time?

[vmarkushin]

I don't know. @Wizdave97 ?

[Wizdave97]

Yeah it could, if the chain updates it's consensus mechanism or has a fork maybe.

[blasrodri]

Can you provide a high level description of the refactor? @vmarkushin

[seunlanlege]

Before i review vlad, can you delete the modules/src/clients folder? Since they'll be maintained outside of this repo

[seunlanlege]

The final step for this pr will be to remove the Any* types and introduce the macro we talked about @vmarkushin

[Wizdave97]

This function is meant to be used when handling misbehaviour messages, we should refactor it to accept take header_1 && header_2, not just one header.

[seunlanlege]

don't think this necessary, because of how 02-client uses it:

ibc-rs/modules/src/core/ics02_client/handler/update_client.rs

Lines 85 to 107 in 04bdb0d

	let found_misbehaviour = client_def
	.check_for_misbehaviour(ctx, client_id.clone(), client_state.clone(), header.clone())
	.map_err(|e| Error::header_verification_failure(e.to_string()))?;
	let event_attributes = Attributes {
	client_id: client_id.clone(),
	height: ctx.host_height(),
	client_type,
	consensus_height: client_state.latest_height(),
	};
	if found_misbehaviour {
	let client_state = client_def.update_state_on_misbehaviour(client_state, header)?;
	let result = ClientResult::Update(Result {
	client_id,
	client_state,
	consensus_state: None,
	processed_time: ctx.host_timestamp(),
	processed_height: ctx.host_height(),
	});
	output.emit(IbcEvent::ClientMisbehaviour(event_attributes.into()));
	return Ok(output.with_result(result));
	}

[Wizdave97]

Yeah, it's not.

[seunlanlege]

So it seems client message should actually be an enum of either Header or Misbehaviour

https://github.com/cosmos/ibc-go/blob/80ea89a356da6606b351f0e00fc82786a5c13fad/modules/core/02-client/keeper/client.go#L53-L88

[seunlanlege]

so it means it shouldn't be ClientDef::verify_header but instead, it should be ClientDef::verify_client_message

https://github.com/cosmos/ibc-go/blob/80ea89a356da6606b351f0e00fc82786a5c13fad/modules/light-clients/07-tendermint/update.go#L21-L33

[seunlanlege]

@Wizdave97 can you make the necessary refactor on this PR?