This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Fix timeout processing #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seunlanlege
reviewed
Sep 5, 2022
| if let Expiry::Expired = packet_timestamp.check_expiry(&proof_timestamp) { | ||
| return Err(Error::packet_timeout_timestamp_not_reached( | ||
| packet_timestamp, | ||
| if !packet.timed_out(&proof_timestamp, proof_height) { |
There was a problem hiding this comment.
shouldn't we check that the timestamp isn't zero before doing this?
There was a problem hiding this comment.
Zero timestamp is represented as None internally and
packet.timed_out function checks that with this self.timeout_timestamp != Timestamp::none()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout messages should be processed successfully if either the timestamp or timeout height is reached.
Packet timeout calculation should be true at exactly the timeout height and timestamp specified in the packet, not at a block higher or timestamp higher
Reference https://github.com/cosmos/ibc-go/blob/main/modules/core/04-channel/keeper/timeout.go#L70-L73