Move data stream component references #12557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
|
/packit build |
Mab879
approved these changes
Oct 31, 2024
|
/packit build |
|
Can you please rebase so the prow CI can run? |
Mab879
requested changes
Nov 4, 2024
SCE checks are checks, they aren't checklists. Therefore, `component-ref` elements pointing to components containing SCE checks shouldn't be children of `checklists` element but they should be children of `checks` element. This change fixes this error message that is produced when running the `oscap info` command on the built data stream: OpenSCAP Error: Internal error: Could not acquire handle to 'scap_org.open-scap_cref_rhel9-checks-sce-timer_dnf-automatic_enabled.sh' source. [/builddir/build/BUILD/openscap-1.4.0/src/DS/ds_sds_session.c:233]
The SCE checks should be listed in `checks` element, not in `checklists` element, because SCE checks are checks, not checklists.
|
I have rebased this PR on the top of the latest upstream master branch. |
|
Code Climate has analyzed commit 678adf7 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
Mab879
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCE checks are checks, they aren't checklists. Therefore,
component-refelements pointing to components containing SCE checks shouldn't be children ofchecklistselement but they should be children ofcheckselement.This change fixes this error message that is produced when running the
oscap infocommand on the built data stream: OpenSCAP Error: Internal error: Could not acquire handle to 'scap_org.open-scap_cref_rhel9-checks-sce-timer_dnf-automatic_enabled.sh' source. [/builddir/build/BUILD/openscap-1.4.0/src/DS/ds_sds_session.c:233]