Introduce new CPE platform for bootable containers #12519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Start a new ephemeral environment with changes proposed in this pull request: Fedora Environment Oracle Linux 8 Environment |
Mab879
reviewed
Oct 18, 2024
| @@ -0,0 +1,18 @@ | |||
| name: cpe:/a:bootc | |||
There was a problem hiding this comment.
This also applies to other immutable OSes like Fedora Silverblue.
Should we rename to something like immutable?
This commit adds a new CPE platform `bootc`. Matches: - bootc (RHEL Image Mode) containers and container images - running bootc (RHEL Image Mode) systems Does not match: - classic containers and container images - normal bare-metal systems or VMs The matching platforms and non-matching platforms can be easily distinguished by checking for presence of the kernel and rpm-ostree RPM packages. Bootable containers and running bootc systems both contain both these packages. Normal bare-metal systems usually don't have the rpm-ostree, normal containers don't contain kernel.
The original definition would match other rpm-ostree based platforms such as Fedora SilverBlue. With this change, we will improve the platform definition so that it will match only the bootable containers and running systems deployed from bootable containers.
Change OVAL test IDs in the bootc platform CPE OVAL to prevent ID collisions during the build. Addressing: CRITICAL: ERROR: it's not possible to use the same ID: inventory_test_kernel_installed for two semantically different OVAL entities
jan-cerny
force-pushed
the
bootc_platform
branch
from
a662a52
to
4470e08
Compare
|
I have rebased this PR on the top of the latest upstream master branch. I have extended the check to not match other immutable platforms and I have fixed the OVAL test IDs. |
Co-authored-by: Matthew Burket <[email protected]>
|
Code Climate has analyzed commit 1849ef6 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.9% (0.0% change). View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new CPE platform
bootc.Matches:
Does not match:
The matching platforms and non-matching platforms can be easily distinguished by checking for presence of the kernel and rpm-ostree RPM packages. Bootable containers and running bootc systems both contain both these packages. Normal bare-metal systems usually don't have the rpm-ostree, normal containers don't contain kernel.