Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide CJIS profile for OL8 #12357

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Xeicker
Copy link
Contributor

@Xeicker Xeicker commented Sep 2, 2024

Description:

  • Hide CJIS profile for OL8

Rationale:

  • This profile is no longer expected in OL8

Signed-off-by: Edgar Aguilar <[email protected]>
@Xeicker Xeicker requested a review from a team as a code owner September 2, 2024 18:46
Copy link

github-actions bot commented Sep 2, 2024

Start a new ephemeral environment with changes proposed in this pull request:

Fedora Environment
Open in Gitpod

Oracle Linux 8 Environment
Open in Gitpod

Copy link

github-actions bot commented Sep 2, 2024

🤖 A k8s content image for this PR is available at:
ghcr.io/complianceascode/k8scontent:12357
This image was built from commit: e257e08

Click here to see how to deploy it

If you alread have Compliance Operator deployed:
utils/build_ds_container.py -i ghcr.io/complianceascode/k8scontent:12357

Otherwise deploy the content and operator together by checking out ComplianceAsCode/compliance-operator and:
CONTENT_IMAGE=ghcr.io/complianceascode/k8scontent:12357 make deploy-local

Copy link

codeclimate bot commented Sep 2, 2024

Code Climate has analyzed commit e257e08 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 59.5% (0.0% change).

View more on Code Climate.

@Xeicker Xeicker added Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates. labels Sep 2, 2024
@jan-cerny jan-cerny added this to the 0.1.75 milestone Sep 3, 2024
Copy link
Member

@marcusburghardt marcusburghardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcusburghardt marcusburghardt self-assigned this Sep 3, 2024
@marcusburghardt
Copy link
Member

Overriding CODEOWNERS as @Xeicker can't approve his own PR.

@marcusburghardt marcusburghardt merged commit 5757c41 into ComplianceAsCode:master Sep 3, 2024
100 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Oracle Linux Oracle Linux product related. Update Profile Issues or pull requests related to Profiles updates.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants